Back to feed

b8943

Apr 27, 2026
Meta/llama.cppCLIvb8943

common: fix missing exports in llama-common (#22340)

  • common: refactor common/debug to move abort_on_nan into base_callback_data

Passing bool abort_on_nan as template parameter for common_debug_cb_eval is unnecessary and creates an issue with LTO. It should just be a member of the base_callback_data instead.

  • cont : cleanup

  • common : use pimpl in debug.h to reduce header dependencies

Move common_debug_cb_user_data's data members (std::regex, std::vector) into a private impl struct in debug.cpp.

This removes the includes of common.h and from debug.h, reducing transitive dependencies for any translation unit that includes the header.

Assisted-by: llama.cpp:local pi


Co-authored-by: Georgi Gerganov ggerganov@gmail.com

macOS/iOS:

Linux:

Android:

Windows:

openEuler: